tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt - Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt

Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and fix test error from previous CL Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp ('k') | tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt

diff --git a/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt b/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt

index 2395965968a0471c92f3fc406816187858e8de8d..07b833bc89c5a7299a560c19b50014218a87e341 100644

--- a/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt

+++ b/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt

@@ -1,11 +1,11 @@

In file included from class_does_not_require_finalization.cpp:5:

./class_does_not_require_finalization.h:18:1: warning: [blink-gc] Class 'DoesNotNeedFinalizer' may not require finalization.

-class DoesNotNeedFinalizer : public GarbageCollectedFinalized<DoesNotNeedFinalizer> {

+class DoesNotNeedFinalizer

-./class_does_not_require_finalization.h:23:1: warning: [blink-gc] Class 'DoesNotNeedFinalizer2' may not require finalization.

-class DoesNotNeedFinalizer2 : public GarbageCollectedFinalized<DoesNotNeedFinalizer2> {

+./class_does_not_require_finalization.h:24:1: warning: [blink-gc] Class 'DoesNotNeedFinalizer2' may not require finalization.

+class DoesNotNeedFinalizer2

-./class_does_not_require_finalization.h:34:1: warning: [blink-gc] Class 'DoesNotNeedFinalizer3' may not require finalization.

-class DoesNotNeedFinalizer3 : public GarbageCollectedFinalized<DoesNotNeedFinalizer3>, public HasEmptyDtor {

+./class_does_not_require_finalization.h:36:1: warning: [blink-gc] Class 'DoesNotNeedFinalizer3' may not require finalization.

+class DoesNotNeedFinalizer3

3 warnings generated.