tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt - Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt

Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and fix test error from previous CL Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h ('k') | tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt

diff --git a/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt b/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt

index 890de1073e4f258f99de97a07de2062ec0be6d4a..38f2e77f6318c5c60dd3f39403626495e772b6fd 100644

--- a/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt

+++ b/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt

@@ -2,4 +2,7 @@ In file included from polymorphic_class_with_non_virtual_trace.cpp:5:

./polymorphic_class_with_non_virtual_trace.h:17:1: warning: [blink-gc] Left-most base class 'NonPolymorphicBase' of derived class 'IsNotLeftMostPolymorphic' must be polymorphic.

class NonPolymorphicBase {

-1 warning generated.

+./polymorphic_class_with_non_virtual_trace.h:45:1: warning: [blink-gc] Left-most base class 'TemplatedNonPolymorphicBase<blink::TemplatedIsNotLeftMostPolymorphic>' of derived class 'TemplatedIsNotLeftMostPolymorphic' must be polymorphic.

+class TemplatedNonPolymorphicBase

+2 warnings generated.