tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt - Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt

Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and fix test error from previous CL Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp ('k') | tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 In file included from class_does_not_require_finalization.cpp:5:	1 In file included from class_does_not_require_finalization.cpp:5:

2 ./class_does_not_require_finalization.h:18:1: warning: [blink-gc] Class 'DoesNot NeedFinalizer' may not require finalization.	2 ./class_does_not_require_finalization.h:18:1: warning: [blink-gc] Class 'DoesNot NeedFinalizer' may not require finalization.

3 class DoesNotNeedFinalizer : public GarbageCollectedFinalized<DoesNotNeedFinaliz er> {	3 class DoesNotNeedFinalizer

4 ^	4 ^

5 ./class_does_not_require_finalization.h:23:1: warning: [blink-gc] Class 'DoesNot NeedFinalizer2' may not require finalization.	5 ./class_does_not_require_finalization.h:24:1: warning: [blink-gc] Class 'DoesNot NeedFinalizer2' may not require finalization.

6 class DoesNotNeedFinalizer2 : public GarbageCollectedFinalized<DoesNotNeedFinali zer2> {	6 class DoesNotNeedFinalizer2

7 ^	7 ^

8 ./class_does_not_require_finalization.h:34:1: warning: [blink-gc] Class 'DoesNot NeedFinalizer3' may not require finalization.	8 ./class_does_not_require_finalization.h:36:1: warning: [blink-gc] Class 'DoesNot NeedFinalizer3' may not require finalization.

9 class DoesNotNeedFinalizer3 : public GarbageCollectedFinalized<DoesNotNeedFinali zer3>, public HasEmptyDtor {	9 class DoesNotNeedFinalizer3

10 ^	10 ^

11 3 warnings generated.	11 3 warnings generated.

OLD	NEW