tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt - Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt

Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and fix test error from previous CL Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 In file included from virtual_and_trace_after_dispatch.cpp:5:	1 In file included from virtual_and_trace_after_dispatch.cpp:5:

	2 ./virtual_and_trace_after_dispatch.h:12:1: warning: [blink-gc] Left-most base cl ass 'A' of derived class 'B' must be polymorphic.

	3 class A : public GarbageCollected<A> {

	4 ^

2 ./virtual_and_trace_after_dispatch.h:23:1: warning: [blink-gc] Class 'B' contain s or inherits virtual methods but implements manual dispatching.	5 ./virtual_and_trace_after_dispatch.h:23:1: warning: [blink-gc] Class 'B' contain s or inherits virtual methods but implements manual dispatching.

3 class B : public A {	6 class B : public A {

4 ^	7 ^

5 ./virtual_and_trace_after_dispatch.h:14:5: note: [blink-gc] Manual dispatch 'tra ce' declared here:	8 ./virtual_and_trace_after_dispatch.h:14:5: note: [blink-gc] Manual dispatch 'tra ce' declared here:

6 void trace(Visitor*);	9 void trace(Visitor*);

7 ^	10 ^

8 1 warning generated.	11 2 warnings generated.

OLD	NEW

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt ('k') | no next file » | no next file with comments »