Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 562233002: Don't allow creating a profile with an empty name in chrome://settings (Closed)

Created:
6 years, 3 months ago by noms (inactive)
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't allow creating a profile with an empty name in chrome://settings This is something I missed in https://codereview.chromium.org/532023003 BUG=413116 TEST=Go to chrome://settings and create a new profile. You should not be able to save a name that's all spaces. Committed: https://crrev.com/2c8708ccafd15405e23d1ad4b3bb5c1adfb2a1f3 Cr-Commit-Position: refs/heads/master@{#295064}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : added empty string checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/options/manage_profile_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
noms (inactive)
Hi Dan, I missed setting a no-spaces-allowed pattern on the the new profile name text ...
6 years, 3 months ago (2014-09-11 15:22:25 UTC) #2
Dan Beam
lgtm but see previous review (https://codereview.chromium.org/532023003/)
6 years, 3 months ago (2014-09-11 17:54:17 UTC) #3
noms (inactive)
Added the comments from https://codereview.chromium.org/532023003/
6 years, 3 months ago (2014-09-15 21:11:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562233002/40001
6 years, 3 months ago (2014-09-16 13:58:38 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e0bf2bd1e88aec46d3703f47f4bea04cf57617e9
6 years, 3 months ago (2014-09-16 14:52:57 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:01:24 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2c8708ccafd15405e23d1ad4b3bb5c1adfb2a1f3
Cr-Commit-Position: refs/heads/master@{#295064}

Powered by Google App Engine
This is Rietveld 408576698