[Profiles] Trim profile names in chrome://settings

[Profiles] Trim profile names in chrome://settings

And validate them accordingly (all-space names are still empty and invalid).

BUG=405913
TEST=Go to chrome://settings. Try to enter "      " for the profile name. The
textbox should stay red. Enter "     batman    " for the profile name, and save.
The name should be saved as just "batman". Expect some bat signals.

Committed: https://crrev.com/242124e818794d0d64fb001466795863abe37374
Cr-Commit-Position: refs/heads/master@{#293571}

[noms (inactive), 2014-09-03 15:06:37]

noms@chromium.org changed reviewers:
+ dbeam@chromium.org

[noms (inactive), 2014-09-03 15:06:38]

Hi Dan,

Trimming ALL the profile names. Please take a look. Thanks!

[noms (inactive), 2014-09-04 19:14:16]

Ping!

[Dan Beam, 2014-09-04 23:06:07]

why can't we just put pattern=".*\S.*" on the <input> and trim in C++?

https://codereview.chromium.org/532023003/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/manage_profile_overlay.js (right):

https://codereview.chromium.org/532023003/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/manage_profile_overlay.js:427: var nameElement
= $(mode + '-profile-name');
nit: move a line lower (right above first use)

[noms (inactive), 2014-09-05 15:34:14]

Oh, I didn't know patterns were an option. :/

Took your suggestion, moved the trimming to c++.

[Dan Beam, 2014-09-05 17:57:33]

lgtm

[noms (inactive), 2014-09-05 18:59:56]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-09-05 19:01:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noms@chromium.org/532023003/20001

[commit-bot: I haz the power, 2014-09-05 20:05:27]

Committed patchset #2 (id:20001) as 7d2c22788eb96cbb8e30689d7c2e8de8a6f0c753

[commit-bot: I haz the power, 2014-09-10 03:41:15]

Patchset 2 (id:??) landed as
https://crrev.com/242124e818794d0d64fb001466795863abe37374
Cr-Commit-Position: refs/heads/master@{#293571}

[Dan Beam, 2014-09-11 17:54:08]

probably should've done this (or should do it at a lower level when creating
profiles)

https://codereview.chromium.org/532023003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/create_profile_handler.cc (right):

https://codereview.chromium.org/532023003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/create_profile_handler.cc:84:
base::TrimWhitespace(name, base::TRIM_ALL, &name);
CHECK(!name.empty());

https://codereview.chromium.org/532023003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/manage_profile_handler.cc (right):

https://codereview.chromium.org/532023003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/manage_profile_handler.cc:385:
base::TrimWhitespace(new_profile_name, base::TRIM_ALL, &new_profile_name);
CHECK(!new_profile_name.empty());

[noms (inactive), 2014-09-15 21:12:26]

https://codereview.chromium.org/532023003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/create_profile_handler.cc (right):

https://codereview.chromium.org/532023003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/create_profile_handler.cc:84:
base::TrimWhitespace(name, base::TRIM_ALL, &name);
On 2014/09/11 17:54:08, Dan Beam wrote:
> CHECK(!name.empty());

Done in https://codereview.chromium.org/562233002.

https://codereview.chromium.org/532023003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/manage_profile_handler.cc (right):

https://codereview.chromium.org/532023003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/manage_profile_handler.cc:385:
base::TrimWhitespace(new_profile_name, base::TRIM_ALL, &new_profile_name);
On 2014/09/11 17:54:08, Dan Beam wrote:
> CHECK(!new_profile_name.empty());

Done in https://codereview.chromium.org/562233002.