chrome/browser/ui/webui/options/create_profile_handler.cc - Issue 562233002: Don't allow creating a profile with an empty name in chrome://settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/create_profile_handler.cc

Issue 562233002: Don't allow creating a profile with an empty name in chrome://settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added empty string checks Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/manage_profile_overlay.html ('k') | chrome/browser/ui/webui/options/manage_profile_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/create_profile_handler.cc

diff --git a/chrome/browser/ui/webui/options/create_profile_handler.cc b/chrome/browser/ui/webui/options/create_profile_handler.cc

index 8d722e7349a54212a053127cbdb408f95caad431..135c8763c587f24968ab29f103e1a54bbc548453 100644

--- a/chrome/browser/ui/webui/options/create_profile_handler.cc

+++ b/chrome/browser/ui/webui/options/create_profile_handler.cc

@@ -82,6 +82,7 @@ void CreateProfileHandler::CreateProfile(const base::ListValue* args) {

bool supervised_user = false;

if (args->GetString(0, &name) && args->GetString(1, &icon)) {

base::TrimWhitespace(name, base::TRIM_ALL, &name);

+ CHECK(!name.empty());

if (args->GetBoolean(2, &create_shortcut)) {

bool success = args->GetBoolean(3, &supervised_user);

DCHECK(success);