chrome/browser/ui/webui/options/manage_profile_handler.cc - Issue 562233002: Don't allow creating a profile with an empty name in chrome://settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/manage_profile_handler.cc

Issue 562233002: Don't allow creating a profile with an empty name in chrome://settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added empty string checks Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/manage_profile_handler.cc

diff --git a/chrome/browser/ui/webui/options/manage_profile_handler.cc b/chrome/browser/ui/webui/options/manage_profile_handler.cc

index cb99c53ad86fb410549ab56b0351d11d950fce53..34fc5e66a7f6e2ab16542e3593d02a5999098027 100644

--- a/chrome/browser/ui/webui/options/manage_profile_handler.cc

+++ b/chrome/browser/ui/webui/options/manage_profile_handler.cc

@@ -383,6 +383,7 @@ void ManageProfileHandler::SetProfileIconAndName(const base::ListValue* args) {

return;

base::TrimWhitespace(new_profile_name, base::TRIM_ALL, &new_profile_name);

+ CHECK(!new_profile_name.empty());

profiles::UpdateProfileName(profile, new_profile_name);

}

« no previous file with comments | « chrome/browser/ui/webui/options/create_profile_handler.cc ('k') | no next file » | no next file with comments »