Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: chrome/browser/resources/options/manage_profile_overlay.html

Issue 562233002: Don't allow creating a profile with an empty name in chrome://settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added empty string checks Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/create_profile_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <div id="manage-profile-overlay" class="page" hidden> 1 <div id="manage-profile-overlay" class="page" hidden>
2 <div class="close-button"></div> 2 <div class="close-button"></div>
3 <!-- Dialog for managing profiles. --> 3 <!-- Dialog for managing profiles. -->
4 <div id="manage-profile-overlay-manage" hidden> 4 <div id="manage-profile-overlay-manage" hidden>
5 <h1 i18n-content="manageProfile"></h1> 5 <h1 i18n-content="manageProfile"></h1>
6 <div id="manage-profile-content" class="content-area"> 6 <div id="manage-profile-content" class="content-area">
7 <div id="manage-profile-icon-label" 7 <div id="manage-profile-icon-label"
8 i18n-content="manageProfilesIconLabel"> 8 i18n-content="manageProfilesIconLabel">
9 </div> 9 </div>
10 <grid id="manage-profile-icon-grid"></grid> 10 <grid id="manage-profile-icon-grid"></grid>
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 <div id="manage-profile-overlay-create" hidden> 79 <div id="manage-profile-overlay-create" hidden>
80 <h1 i18n-content="createProfileTitle"></h1> 80 <h1 i18n-content="createProfileTitle"></h1>
81 <div id="create-profile-content" class="content-area"> 81 <div id="create-profile-content" class="content-area">
82 <div id="create-profile-instructions"></div> 82 <div id="create-profile-instructions"></div>
83 <grid id="create-profile-icon-grid"></grid> 83 <grid id="create-profile-icon-grid"></grid>
84 <div id="create-profile-name-input-container"> 84 <div id="create-profile-name-input-container">
85 <label> 85 <label>
86 <span id="create-profile-name-label" for="create-profile-name" 86 <span id="create-profile-name-label" for="create-profile-name"
87 i18n-content="manageProfilesNameLabel"> 87 i18n-content="manageProfilesNameLabel">
88 </span> 88 </span>
89 <input id="create-profile-name" type="text" required> 89 <input id="create-profile-name" type="text" pattern=".*\S.*" required>
90 </label> 90 </label>
91 </div> 91 </div>
92 </div> 92 </div>
93 <div id="create-profile-supervised-content-area" class="content-area"> 93 <div id="create-profile-supervised-content-area" class="content-area">
94 <div id="create-shortcut-container" class="checkbox" hidden> 94 <div id="create-shortcut-container" class="checkbox" hidden>
95 <label> 95 <label>
96 <input id="create-shortcut" type="checkbox"> 96 <input id="create-shortcut" type="checkbox">
97 <span for="create-shortcut" 97 <span for="create-shortcut"
98 i18n-content="createProfileShortcutCheckbox"> 98 i18n-content="createProfileShortcutCheckbox">
99 </span> 99 </span>
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 </button> 133 </button>
134 <div class="button-strip"> 134 <div class="button-strip">
135 <button id="create-profile-cancel" i18n-content="cancel"></button> 135 <button id="create-profile-cancel" i18n-content="cancel"></button>
136 <button id="create-profile-ok" i18n-content="createProfileConfirm" 136 <button id="create-profile-ok" i18n-content="createProfileConfirm"
137 class="default-button"> 137 class="default-button">
138 </button> 138 </button>
139 </div> 139 </div>
140 </div> 140 </div>
141 </div> 141 </div>
142 </div> 142 </div>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/create_profile_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698