Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 560913006: Changing the Weakptr initialization order in chrome/browser/extension folder (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, lgombos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changing the Weakptr initialization order Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/63d6300f39f31888597c1c3b40fca8ed9426da91 Cr-Commit-Position: refs/heads/master@{#295004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M chrome/browser/extensions/api/idle/idle_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/tab_helper.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_cache_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_cache_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MRV
PTAL
6 years, 3 months ago (2014-09-15 11:13:36 UTC) #2
sky
How about a more local owner: sky->yoz
6 years, 3 months ago (2014-09-15 16:05:16 UTC) #4
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-15 18:55:45 UTC) #5
MRV
On 2014/09/15 18:55:45, Yoyo Zhou wrote: > LGTM Thanks mr.yoyo zhou for lgtm
6 years, 3 months ago (2014-09-16 02:06:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560913006/1
6 years, 3 months ago (2014-09-16 02:19:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as a8e08c27fdbf4189fbda4dc09613c9cb12074f62
6 years, 3 months ago (2014-09-16 04:14:48 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 04:16:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63d6300f39f31888597c1c3b40fca8ed9426da91
Cr-Commit-Position: refs/heads/master@{#295004}

Powered by Google App Engine
This is Rietveld 408576698