chrome/browser/extensions/updater/extension_updater.h - Issue 560913006: Changing the Weakptr initialization order in chrome/browser/extension folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_updater.h

Issue 560913006: Changing the Weakptr initialization order in chrome/browser/extension folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/extension_downloader.cc ('k') | chrome/browser/extensions/updater/extension_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/updater/extension_updater.h

diff --git a/chrome/browser/extensions/updater/extension_updater.h b/chrome/browser/extensions/updater/extension_updater.h

index 88401da4656f604539fa3527f1869c446e18245d..30480348ed81948de38dadcdb7b7c8eab4d90457 100644

--- a/chrome/browser/extensions/updater/extension_updater.h

+++ b/chrome/browser/extensions/updater/extension_updater.h

@@ -241,8 +241,6 @@ class ExtensionUpdater : public ExtensionDownloaderDelegate,

// Whether Start() has been called but not Stop().

bool alive_;

- base::WeakPtrFactory<ExtensionUpdater> weak_ptr_factory_;

// Pointer back to the service that owns this ExtensionUpdater.

ExtensionServiceInterface* service_;

@@ -290,6 +288,8 @@ class ExtensionUpdater : public ExtensionDownloaderDelegate,

// next update check.

std::set<std::string> forced_updates_;

+ base::WeakPtrFactory<ExtensionUpdater> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(ExtensionUpdater);

};