chrome/browser/extensions/updater/extension_downloader.cc - Issue 560913006: Changing the Weakptr initialization order in chrome/browser/extension folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_downloader.cc

Issue 560913006: Changing the Weakptr initialization order in chrome/browser/extension folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/extension_downloader.h ('k') | chrome/browser/extensions/updater/extension_updater.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/updater/extension_downloader.cc

diff --git a/chrome/browser/extensions/updater/extension_downloader.cc b/chrome/browser/extensions/updater/extension_downloader.cc

index 4a0273d271f87a5d0abf1e890ac6a78dee12c21d..a8df87a01ebeff7a274c05505ed81bf51c5d39c0 100644

--- a/chrome/browser/extensions/updater/extension_downloader.cc

+++ b/chrome/browser/extensions/updater/extension_downloader.cc

@@ -180,14 +180,14 @@ ExtensionDownloader::ExtensionDownloader(

: OAuth2TokenService::Consumer(kTokenServiceConsumerId),

delegate_(delegate),

request_context_(request_context),

- weak_ptr_factory_(this),

manifests_queue_(&kDefaultBackoffPolicy,

base::Bind(&ExtensionDownloader::CreateManifestFetcher,

base::Unretained(this))),

extensions_queue_(&kDefaultBackoffPolicy,

base::Bind(&ExtensionDownloader::CreateExtensionFetcher,

base::Unretained(this))),

- extension_cache_(NULL) {

+ extension_cache_(NULL),

+ weak_ptr_factory_(this) {

DCHECK(delegate_);

DCHECK(request_context_.get());

}

« no previous file with comments | « chrome/browser/extensions/updater/extension_downloader.h ('k') | chrome/browser/extensions/updater/extension_updater.h » ('j') | no next file with comments »