chrome/browser/extensions/updater/extension_cache_impl.cc - Issue 560913006: Changing the Weakptr initialization order in chrome/browser/extension folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_cache_impl.cc

Issue 560913006: Changing the Weakptr initialization order in chrome/browser/extension folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/extension_cache_impl.h ('k') | chrome/browser/extensions/updater/extension_downloader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/updater/extension_cache_impl.cc

diff --git a/chrome/browser/extensions/updater/extension_cache_impl.cc b/chrome/browser/extensions/updater/extension_cache_impl.cc

index f79eab8ffa43bb7fceef8b99bdad6fee0727e79f..78698a479236d5dc6700b2488a17154f673e2624 100644

--- a/chrome/browser/extensions/updater/extension_cache_impl.cc

+++ b/chrome/browser/extensions/updater/extension_cache_impl.cc

@@ -41,14 +41,14 @@ ExtensionCacheImpl* ExtensionCacheImpl::GetInstance() {

}

ExtensionCacheImpl::ExtensionCacheImpl()

- : weak_ptr_factory_(this),

- cache_(new LocalExtensionCache(base::FilePath(kLocalCacheDir),

+ : cache_(new LocalExtensionCache(base::FilePath(kLocalCacheDir),

kMaxCacheSize,

base::TimeDelta::FromDays(kMaxCacheAgeDays),

content::BrowserThread::GetBlockingPool()->

GetSequencedTaskRunnerWithShutdownBehavior(

content::BrowserThread::GetBlockingPool()->GetSequenceToken(),

- base::SequencedWorkerPool::SKIP_ON_SHUTDOWN))) {

+ base::SequencedWorkerPool::SKIP_ON_SHUTDOWN))),

+ weak_ptr_factory_(this) {

notification_registrar_.Add(

this,

extensions::NOTIFICATION_EXTENSION_INSTALL_ERROR,