Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1987)

Unified Diff: chrome/browser/extensions/updater/extension_cache_impl.h

Issue 560913006: Changing the Weakptr initialization order in chrome/browser/extension folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/tab_helper.cc ('k') | chrome/browser/extensions/updater/extension_cache_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/updater/extension_cache_impl.h
diff --git a/chrome/browser/extensions/updater/extension_cache_impl.h b/chrome/browser/extensions/updater/extension_cache_impl.h
index 4c821c4288fce8380119cf2b37437423737c9120..a1223eead24fef4dcc7b6b1c008a7665a49ad82e 100644
--- a/chrome/browser/extensions/updater/extension_cache_impl.h
+++ b/chrome/browser/extensions/updater/extension_cache_impl.h
@@ -56,9 +56,6 @@ class ExtensionCacheImpl : public ExtensionCache,
// Callback that is called when local cache is ready.
void OnCacheInitialized();
- // Weak factory for callbacks.
- base::WeakPtrFactory<ExtensionCacheImpl> weak_ptr_factory_;
-
// Cache implementation that uses local cache dir.
scoped_ptr<LocalExtensionCache> cache_;
@@ -71,6 +68,9 @@ class ExtensionCacheImpl : public ExtensionCache,
// Observes failures to install CRX files.
content::NotificationRegistrar notification_registrar_;
+ // Weak factory for callbacks.
+ base::WeakPtrFactory<ExtensionCacheImpl> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ExtensionCacheImpl);
};
« no previous file with comments | « chrome/browser/extensions/tab_helper.cc ('k') | chrome/browser/extensions/updater/extension_cache_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698