Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558603002: [SyncFS] Make MetadataDatabase operations synchronous (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@01_create
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Make MetadataDatabase operations synchronous BUG=412367 Committed: https://crrev.com/a301aef21f9e42c81728a7b38847b2b77aa46903 Cr-Commit-Position: refs/heads/master@{#294087}

Patch Set 1 #

Patch Set 2 : #

Total comments: 14

Patch Set 3 : +TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -330 lines) Patch
M chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.cc View 1 2 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 1 2 9 chunks +24 lines, -42 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.h View 1 9 chunks +28 lines, -51 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 27 chunks +71 lines, -104 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 1 2 chunks +14 lines, -52 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 1 2 4 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 1 2 2 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 1 2 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 1 1 chunk +10 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/uninstall_app_task.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tzik
PTL
6 years, 3 months ago (2014-09-09 14:48:15 UTC) #2
peria
https://codereview.chromium.org/558603002/diff/20001/chrome/browser/sync_file_system/drive_backend/folder_creator.cc File chrome/browser/sync_file_system/drive_backend/folder_creator.cc (right): https://codereview.chromium.org/558603002/diff/20001/chrome/browser/sync_file_system/drive_backend/folder_creator.cc#newcode117 chrome/browser/sync_file_system/drive_backend/folder_creator.cc:117: DidUpdateDatabase(file_id, callback, status); Expand DidUpdateDatabase() here. https://codereview.chromium.org/558603002/diff/20001/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc File chrome/browser/sync_file_system/drive_backend/list_changes_task.cc ...
6 years, 3 months ago (2014-09-10 00:24:16 UTC) #3
tzik
https://codereview.chromium.org/558603002/diff/20001/chrome/browser/sync_file_system/drive_backend/folder_creator.cc File chrome/browser/sync_file_system/drive_backend/folder_creator.cc (right): https://codereview.chromium.org/558603002/diff/20001/chrome/browser/sync_file_system/drive_backend/folder_creator.cc#newcode117 chrome/browser/sync_file_system/drive_backend/folder_creator.cc:117: DidUpdateDatabase(file_id, callback, status); On 2014/09/10 00:24:15, peria wrote: > ...
6 years, 3 months ago (2014-09-10 00:56:55 UTC) #4
peria
lgtm
6 years, 3 months ago (2014-09-10 01:03:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/558603002/40001
6 years, 3 months ago (2014-09-10 01:09:29 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e422774d4e6ed39ea40f4b8e7fb3729de9e37b36
6 years, 3 months ago (2014-09-10 03:21:35 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:58:39 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a301aef21f9e42c81728a7b38847b2b77aa46903
Cr-Commit-Position: refs/heads/master@{#294087}

Powered by Google App Engine
This is Rietveld 408576698