Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2791)

Unified Diff: chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc

Issue 558603002: [SyncFS] Make MetadataDatabase operations synchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_create
Patch Set: +TODO Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc b/chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc
index c7809305d7484280304350216c8b1aa83df5bfea..a4413978b48efe438241b1e6479ca2742ad6aa79 100644
--- a/chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc
+++ b/chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc
@@ -268,8 +268,9 @@ void ConflictResolver::DidRemoveFile(scoped_ptr<SyncTaskToken> token,
return;
}
- metadata_database()->UpdateByDeletedRemoteFileList(
- deleted_file_ids_, SyncTaskToken::WrapToCallback(token.Pass()));
+ status = metadata_database()->UpdateByDeletedRemoteFileList(
+ deleted_file_ids_);
+ SyncTaskManager::NotifyTaskDone(token.Pass(), status);
}
bool ConflictResolver::IsContextReady() {
@@ -299,8 +300,8 @@ void ConflictResolver::DidGetRemoteMetadata(
}
if (error != google_apis::HTTP_NOT_FOUND) {
- metadata_database()->UpdateByDeletedRemoteFile(
- file_id, SyncTaskToken::WrapToCallback(token.Pass()));
+ status = metadata_database()->UpdateByDeletedRemoteFile(file_id);
+ SyncTaskManager::NotifyTaskDone(token.Pass(), status);
return;
}
@@ -310,8 +311,8 @@ void ConflictResolver::DidGetRemoteMetadata(
return;
}
- metadata_database()->UpdateByFileResource(
- *entry, SyncTaskToken::WrapToCallback(token.Pass()));
+ status = metadata_database()->UpdateByFileResource(*entry);
+ SyncTaskManager::NotifyTaskDone(token.Pass(), status);
}
drive::DriveServiceInterface* ConflictResolver::drive_service() {
« no previous file with comments | « no previous file | chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698