Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc

Issue 558603002: [SyncFS] Make MetadataDatabase operations synchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_create
Patch Set: +TODO Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc b/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
index 4220a6cc6583cb8a839928c2e391254401ca0627..209a4044e7270fdcbbb48ce00e77ee10ce3a37ba 100644
--- a/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
@@ -107,12 +107,8 @@ class SyncEngineInitializerTest : public testing::Test {
const google_apis::FileResource** app_roots,
size_t app_roots_count) {
SyncStatusCode status = SYNC_STATUS_UNKNOWN;
- scoped_ptr<MetadataDatabase> database;
- MetadataDatabase::Create(
- database_path(),
- in_memory_env_.get(),
- CreateResultReceiver(&status, &database));
- base::RunLoop().RunUntilIdle();
+ scoped_ptr<MetadataDatabase> database = MetadataDatabase::Create(
+ database_path(), in_memory_env_.get(), &status);
if (status != SYNC_STATUS_OK)
return status;
@@ -124,16 +120,11 @@ class SyncEngineInitializerTest : public testing::Test {
const_cast<google_apis::FileResource*>(app_roots[i]));
}
- status = SYNC_STATUS_UNKNOWN;
- database->PopulateInitialData(kInitialLargestChangeID,
- sync_root,
- app_root_list,
- CreateResultReceiver(&status));
- base::RunLoop().RunUntilIdle();
+ status = database->PopulateInitialData(
+ kInitialLargestChangeID, sync_root, app_root_list);
app_root_list.weak_clear();
-
- return SYNC_STATUS_OK;
+ return status;
}
scoped_ptr<google_apis::FileResource> CreateRemoteFolder(

Powered by Google App Engine
This is Rietveld 408576698