chrome/browser/sync_file_system/drive_backend/register_app_task.cc - Issue 558603002: [SyncFS] Make MetadataDatabase operations synchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/register_app_task.cc

Issue 558603002: [SyncFS] Make MetadataDatabase operations synchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_create

Patch Set: +TODO Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/register_app_task.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/register_app_task.cc b/chrome/browser/sync_file_system/drive_backend/register_app_task.cc

index 74881d241b0e8a69753e6704cae66b1239e14e00..9ab0bd5a309d1e14a7de0970984e757ec8d86579 100644

--- a/chrome/browser/sync_file_system/drive_backend/register_app_task.cc

+++ b/chrome/browser/sync_file_system/drive_backend/register_app_task.cc

@@ -168,8 +168,9 @@ bool RegisterAppTask::FilterCandidates(const TrackerIDSet& trackers,

void RegisterAppTask::RegisterAppIntoDatabase(

const FileTracker& tracker,

const SyncStatusCallback& callback) {

- metadata_database()->RegisterApp(

- app_id_, tracker.file_id(), callback);

+ SyncStatusCode status =

+ metadata_database()->RegisterApp(app_id_, tracker.file_id());

+ callback.Run(status);

}

MetadataDatabase* RegisterAppTask::metadata_database() {