Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6349)

Unified Diff: chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

Issue 558603002: [SyncFS] Make MetadataDatabase operations synchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_create
Patch Set: +TODO Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/list_changes_task.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc b/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc
index 0c6a1bd0dde030da98b0d26dbc80122c03bed4f0..92739047fd09f7c2fca77cef716ca9972eb3e5f5 100644
--- a/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc
+++ b/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/sync_file_system/drive_backend/list_changes_task.h"
+#include <vector>
+
#include "base/bind.h"
#include "base/format_macros.h"
#include "base/location.h"
@@ -118,11 +120,12 @@ void ListChangesTask::CheckInChangeList(int64 largest_change_id,
for (size_t i = 0; i < change_list_.size(); ++i)
file_ids_.push_back(change_list_[i]->file_id());
- metadata_database()->UpdateByChangeList(
- largest_change_id,
- change_list_.Pass(),
- base::Bind(&ListChangesTask::DidCheckInChangeList,
- weak_ptr_factory_.GetWeakPtr(), base::Passed(&token)));
+ SyncStatusCode status =
+ metadata_database()->UpdateByChangeList(
+ largest_change_id, change_list_.Pass());
+
+ // TODO(tzik): Expand this function.
+ DidCheckInChangeList(token.Pass(), status);
}
void ListChangesTask::DidCheckInChangeList(scoped_ptr<SyncTaskToken> token,
@@ -132,9 +135,8 @@ void ListChangesTask::DidCheckInChangeList(scoped_ptr<SyncTaskToken> token,
return;
}
- metadata_database()->SweepDirtyTrackers(
- file_ids_,
- base::Bind(&SyncTaskManager::NotifyTaskDone, base::Passed(&token)));
+ status = metadata_database()->SweepDirtyTrackers(file_ids_);
+ SyncTaskManager::NotifyTaskDone(token.Pass(), status);
}
bool ListChangesTask::IsContextReady() {

Powered by Google App Engine
This is Rietveld 408576698