Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 555343002: gn: make some warning flags match gyp more closely (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn: make some warning flags match gyp more closely This fixes differences in -Wno-unused-function and -Wno-unneeded-internal-declaration. It also changes the diff'ing script to accept -Wendif-labels -Wextra -Wsign-compare when in GN but not gyp, because they're more conservative. These mostly happen when GN declares a lib chromium_code, but gyp doesn't. Also, remove some defines from the dont_care, as I'm not sure that we don't care yet. And some minor tweaks to diff script output. R=brettw@chromium.org BUG=335824 Committed: https://crrev.com/e8d3adb185373b15d593855f623fb5e28ef7878c Cr-Commit-Position: refs/heads/master@{#294229}

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : disable unused function warning in generated cython code #

Patch Set 4 : . #

Patch Set 5 : breakpad:processor_support non-chromium_code #

Patch Set 6 : breakpad:minidump_dump non-chromium_code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -22 lines) Patch
M breakpad/BUILD.gn View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/cython/rules.gni View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gn/bin/gyp_flag_compare.py View 1 2 3 4 3 chunks +27 lines, -20 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
scottmg
6 years, 3 months ago (2014-09-10 00:12:12 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-10 00:13:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/555343002/160001
6 years, 3 months ago (2014-09-10 18:52:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10046) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/14174)
6 years, 3 months ago (2014-09-10 19:20:20 UTC) #10
scottmg
+thestig for breakpad/BUILD.gn -- made targets non-chromium_code which matches gyp.
6 years, 3 months ago (2014-09-10 19:22:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/555343002/180001
6 years, 3 months ago (2014-09-10 19:23:23 UTC) #14
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-10 19:25:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/14198)
6 years, 3 months ago (2014-09-10 19:37:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/555343002/180001
6 years, 3 months ago (2014-09-10 19:39:51 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:180001) as 7cfe6ed8972c37b41518a26ddafcec2485f2760e
6 years, 3 months ago (2014-09-10 21:10:42 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 21:25:31 UTC) #21
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e8d3adb185373b15d593855f623fb5e28ef7878c
Cr-Commit-Position: refs/heads/master@{#294229}

Powered by Google App Engine
This is Rietveld 408576698