build/config/compiler/BUILD.gn - Issue 555343002: gn: make some warning flags match gyp more closely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 555343002: gn: make some warning flags match gyp more closely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: breakpad:minidump_dump non-chromium_code Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index a028841c24556fa58743f9604f2303f5fcfd1d8f..1e8da2d700d3bf7a3035d871983440f41bb828c2 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -700,8 +700,10 @@ config("default_warnings") {

# http://crbug.com/255186

"-Wno-deprecated-register",

- # Clang spots more unused functions.

- "-Wno-unused-function",

+ # TODO(thakis): This used to be implied by -Wno-unused-function,

+ # which we no longer use. Check if it makes sense to remove

+ # this as well. http://crbug.com/316352

+ "-Wno-unneeded-internal-declaration",

]

if (!is_mac && !is_ios) {

« no previous file with comments | « breakpad/BUILD.gn ('k') | third_party/cython/rules.gni » ('j') | no next file with comments »