third_party/cython/rules.gni - Issue 555343002: gn: make some warning flags match gyp more closely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/cython/rules.gni

Issue 555343002: gn: make some warning flags match gyp more closely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: breakpad:minidump_dump non-chromium_code Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/cython/rules.gni

diff --git a/third_party/cython/rules.gni b/third_party/cython/rules.gni

index 22a56c3cc9139586f4eefc8d3351d5c9d4f82ef9..fce3e4caf7c4d12997dd9bcc812486cc604c8b0e 100644

--- a/third_party/cython/rules.gni

+++ b/third_party/cython/rules.gni

@@ -52,6 +52,12 @@ template("python_binary_module") {

lib_dirs = exec_script(python_flags,

[ "--gn", "--library_dirs" ],

"list lines")

+ if (!is_win) {

+ # Generated code includes static utility functions that often go unused.

+ cflags = [

+ "-Wno-unused-function",

+ ]

+ }

}

shared_library(shared_library_name) {

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | tools/gn/bin/gyp_flag_compare.py » ('j') | no next file with comments »