Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 555343002: gn: make some warning flags match gyp more closely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: breakpad:minidump_dump non-chromium_code Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « breakpad/BUILD.gn ('k') | third_party/cython/rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 if (cpu_arch == "arm") { 6 if (cpu_arch == "arm") {
7 import("//build/config/arm.gni") 7 import("//build/config/arm.gni")
8 } 8 }
9 if (is_posix) { 9 if (is_posix) {
10 import("//build/config/gcc/gcc_version.gni") 10 import("//build/config/gcc/gcc_version.gni")
(...skipping 682 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 693
694 # Warns on switches on enums that cover all enum values but 694 # Warns on switches on enums that cover all enum values but
695 # also contain a default: branch. Chrome is full of that. 695 # also contain a default: branch. Chrome is full of that.
696 "-Wno-covered-switch-default", 696 "-Wno-covered-switch-default",
697 697
698 # Clang considers the `register` keyword as deprecated, but e.g. 698 # Clang considers the `register` keyword as deprecated, but e.g.
699 # code generated by flex (used in angle) contains that keyword. 699 # code generated by flex (used in angle) contains that keyword.
700 # http://crbug.com/255186 700 # http://crbug.com/255186
701 "-Wno-deprecated-register", 701 "-Wno-deprecated-register",
702 702
703 # Clang spots more unused functions. 703 # TODO(thakis): This used to be implied by -Wno-unused-function,
704 "-Wno-unused-function", 704 # which we no longer use. Check if it makes sense to remove
705 # this as well. http://crbug.com/316352
706 "-Wno-unneeded-internal-declaration",
705 ] 707 ]
706 708
707 if (!is_mac && !is_ios) { 709 if (!is_mac && !is_ios) {
708 cflags_cc += [ 710 cflags_cc += [
709 "-Wno-reserved-user-defined-literal", 711 "-Wno-reserved-user-defined-literal",
710 ] 712 ]
711 } 713 }
712 } 714 }
713 if (gcc_version >= 48) { 715 if (gcc_version >= 48) {
714 cflags_cc += [ 716 cflags_cc += [
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
916 cflags += [ "-gsplit-dwarf" ] 918 cflags += [ "-gsplit-dwarf" ]
917 } 919 }
918 } 920 }
919 } 921 }
920 922
921 config("no_symbols") { 923 config("no_symbols") {
922 if (!is_win) { 924 if (!is_win) {
923 cflags = [ "-g0" ] 925 cflags = [ "-g0" ]
924 } 926 }
925 } 927 }
OLDNEW
« no previous file with comments | « breakpad/BUILD.gn ('k') | third_party/cython/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698