Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: breakpad/BUILD.gn

Issue 555343002: gn: make some warning flags match gyp more closely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: breakpad:minidump_dump non-chromium_code Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("tools_config") { 5 config("tools_config") {
6 include_dirs = [ "src", "src/third_party" ] 6 include_dirs = [ "src", "src/third_party" ]
7 if (is_android) { 7 if (is_android) {
8 defines = [ "__ANDROID__" ] 8 defines = [ "__ANDROID__" ]
9 } 9 }
10 if (is_clang) { 10 if (is_clang) {
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 "src/processor/basic_code_modules.h", 138 "src/processor/basic_code_modules.h",
139 "src/processor/logging.cc", 139 "src/processor/logging.cc",
140 "src/processor/logging.h", 140 "src/processor/logging.h",
141 "src/processor/minidump.cc", 141 "src/processor/minidump.cc",
142 "src/processor/minidump_dump.cc", 142 "src/processor/minidump_dump.cc",
143 "src/processor/pathname_stripper.cc", 143 "src/processor/pathname_stripper.cc",
144 "src/processor/pathname_stripper.h", 144 "src/processor/pathname_stripper.h",
145 ] 145 ]
146 146
147 configs += [ ":tools_config" ] 147 configs += [ ":tools_config" ]
148
149 # There are some warnings in this code.
150 configs -= [ "//build/config/compiler:chromium_code" ]
151 configs += [ "//build/config/compiler:no_chromium_code" ]
148 } 152 }
149 } 153 }
150 154
151 # Mac -------------------------------------------------------------------------- 155 # Mac --------------------------------------------------------------------------
152 156
153 if (current_toolchain == host_toolchain && is_mac) { 157 if (current_toolchain == host_toolchain && is_mac) {
154 # TODO(GYP) This should be only 64-bit on Mac. From .gypi: 158 # TODO(GYP) This should be only 64-bit on Mac. From .gypi:
155 # Like ld, dump_syms needs to operate on enough data that it may 159 # Like ld, dump_syms needs to operate on enough data that it may
156 # actually need to be able to address more than 4GB. Use x86_64. 160 # actually need to be able to address more than 4GB. Use x86_64.
157 # Don't worry! An x86_64 dump_syms is perfectly able to dump 161 # Don't worry! An x86_64 dump_syms is perfectly able to dump
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 "src/processor/pathname_stripper.cc", 475 "src/processor/pathname_stripper.cc",
472 "src/processor/pathname_stripper.h", 476 "src/processor/pathname_stripper.h",
473 ] 477 ]
474 478
475 include_dirs = [ 479 include_dirs = [
476 "src", 480 "src",
477 "src/client", 481 "src/client",
478 "src/third_party/linux/include", 482 "src/third_party/linux/include",
479 ".", 483 ".",
480 ] 484 ]
485
486 # There are some warnings in this code.
487 configs -= [ "//build/config/compiler:chromium_code" ]
488 configs += [ "//build/config/compiler:no_chromium_code" ]
481 } 489 }
482 490
483 test("breakpad_unittests") { 491 test("breakpad_unittests") {
484 sources = [ 492 sources = [
485 "linux/breakpad_googletest_includes.h", 493 "linux/breakpad_googletest_includes.h",
486 "src/client/linux/handler/exception_handler_unittest.cc", 494 "src/client/linux/handler/exception_handler_unittest.cc",
487 "src/client/linux/minidump_writer/cpu_set_unittest.cc", 495 "src/client/linux/minidump_writer/cpu_set_unittest.cc",
488 "src/client/linux/minidump_writer/directory_reader_unittest.cc", 496 "src/client/linux/minidump_writer/directory_reader_unittest.cc",
489 "src/client/linux/minidump_writer/line_reader_unittest.cc", 497 "src/client/linux/minidump_writer/line_reader_unittest.cc",
490 "src/client/linux/minidump_writer/linux_core_dumper_unittest.cc", 498 "src/client/linux/minidump_writer/linux_core_dumper_unittest.cc",
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
683 "src/client/windows/handler/exception_handler.h", 691 "src/client/windows/handler/exception_handler.h",
684 "src/common/windows/guid_string.cc", 692 "src/common/windows/guid_string.cc",
685 "src/common/windows/guid_string.h", 693 "src/common/windows/guid_string.h",
686 "src/google_breakpad/common/minidump_format.h", 694 "src/google_breakpad/common/minidump_format.h",
687 "src/client/windows/crash_generation/minidump_generator.cc", 695 "src/client/windows/crash_generation/minidump_generator.cc",
688 "src/client/windows/crash_generation/minidump_generator.h", 696 "src/client/windows/crash_generation/minidump_generator.h",
689 "src/common/windows/string_utils-inl.h", 697 "src/common/windows/string_utils-inl.h",
690 ] 698 ]
691 } 699 }
692 } 700 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698