Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(76)

Issue 544423002: Convert GN visibility variables to lists. (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
scottmg
CC:
chromium-reviews, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, hguihot+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, aandrey+blink_chromium.org, Ilya Sherman, mikhal+watch_chromium.org, extensions-reviews_chromium.org, vsevik, benquan, ben+mojo_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, miu+watch_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, dmikurube+memory_chromium.org, oshima+watch_chromium.org, jochen+watch_chromium.org, hclam+watch_chromium.org, wfh+watch_chromium.org, avayvod+watch_chromium.org, yurys, pwestin+watch_google.com, Aaron Boodman, dsinclair+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, darin (slow to review), pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert GN visibility variables to lists. Currently this is either a list or a string. However, this is causing some problems because templates can't add to the invoker's visibility list without knowing if the original is a string or a list. In an effort to make this consistent, I'm converting all visibiltiy to be lists, and will remove support for strings in a future build. This exempts cld from header checking since it was confusing GN's header checker. It adds a ppapi header target as well that will be used by libyuv (that requires a roll). TBR=scottmg Committed: https://crrev.com/9af4262ad8020658ee04c07d13a2617af64147b1 Cr-Commit-Position: refs/heads/master@{#293638}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -48 lines) Patch
M base/allocator/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/nspr/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/symbolize/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/xdg_mime/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/xdg_user_dirs/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/testing/gtest/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/cacheinvalidation/src/google/cacheinvalidation/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 2 chunks +11 lines, -2 lines 0 comments Download
M build/toolchain/win/midl.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_locales.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/domain_reliability/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tracing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/generated_extensions_api.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/logging/proto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/proto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 1 chunk +9 lines, -2 lines 0 comments Download
M ppapi/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cld/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/dom_distiller_js/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/protobuf/proto_library.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/yasm_assemble.gni View 1 chunk +2 lines, -1 line 0 comments Download
M tools/generate_library_loader/generate_library_loader.gni View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/webui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/BUILD.gn View 1 4 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years ago (2014-09-06 00:17:53 UTC) #2
scottmg
lgtm
5 years ago (2014-09-06 00:22:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/544423002/20001
5 years ago (2014-09-06 16:12:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9195)
5 years ago (2014-09-06 16:18:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/544423002/20001
5 years ago (2014-09-06 21:17:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1f64c97dfb962688257cd2129ce029b2ee9fe989
5 years ago (2014-09-06 21:22:58 UTC) #10
commit-bot: I haz the power
5 years ago (2014-09-10 03:43:28 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9af4262ad8020658ee04c07d13a2617af64147b1
Cr-Commit-Position: refs/heads/master@{#293638}

Powered by Google App Engine
This is Rietveld 408576698