Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: content/browser/tracing/BUILD.gn

Issue 544423002: Convert GN visibility variables to lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/devtools/BUILD.gn ('k') | content/plugin/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 6
7 # generate_about_tracing puts its files in this directory 7 # generate_about_tracing puts its files in this directory
8 tracing_gen_dir = "$root_gen_dir/content/browser/tracing" 8 tracing_gen_dir = "$root_gen_dir/content/browser/tracing"
9 9
10 # The script just writes filename with no dirs to the .grd, so we always need 10 # The script just writes filename with no dirs to the .grd, so we always need
11 # this file to be in the same directory as the inputs. 11 # this file to be in the same directory as the inputs.
12 tracing_grd = "$tracing_gen_dir/tracing_resources.grd" 12 tracing_grd = "$tracing_gen_dir/tracing_resources.grd"
13 13
14 action("generate_tracing_grd") { 14 action("generate_tracing_grd") {
15 visibility = ":*" 15 visibility = [ ":*" ]
16 script = "generate_trace_viewer_grd.py" 16 script = "generate_trace_viewer_grd.py"
17 17
18 input_pages = [ 18 input_pages = [
19 "$tracing_gen_dir/about_tracing.html", 19 "$tracing_gen_dir/about_tracing.html",
20 "$tracing_gen_dir/about_tracing.js", 20 "$tracing_gen_dir/about_tracing.js",
21 ] 21 ]
22 inputs = input_pages 22 inputs = input_pages
23 outputs = [ tracing_grd ] 23 outputs = [ tracing_grd ]
24 24
25 args = rebase_path(input_pages, target_gen_dir) + [ 25 args = rebase_path(input_pages, target_gen_dir) + [
(...skipping 14 matching lines...) Expand all
40 40
41 # resource_ids has an entry for our .grd file that looks like: 41 # resource_ids has an entry for our .grd file that looks like:
42 # "<(SHARED_INTERMEDIATE_DIR)/content/browser/tracing/tracing_resources.grd" 42 # "<(SHARED_INTERMEDIATE_DIR)/content/browser/tracing/tracing_resources.grd"
43 # and what we pass here should make that resolve to our .grd file. 43 # and what we pass here should make that resolve to our .grd file.
44 defines = [ 44 defines = [
45 "SHARED_INTERMEDIATE_DIR=" + rebase_path(root_gen_dir, root_build_dir), 45 "SHARED_INTERMEDIATE_DIR=" + rebase_path(root_gen_dir, root_build_dir),
46 ] 46 ]
47 47
48 deps = [ ":generate_tracing_grd" ] 48 deps = [ ":generate_tracing_grd" ]
49 } 49 }
OLDNEW
« no previous file with comments | « content/browser/devtools/BUILD.gn ('k') | content/plugin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698