Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1951)

Unified Diff: third_party/yasm/yasm_assemble.gni

Issue 544423002: Convert GN visibility variables to lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/protobuf/proto_library.gni ('k') | tools/generate_library_loader/generate_library_loader.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/yasm/yasm_assemble.gni
diff --git a/third_party/yasm/yasm_assemble.gni b/third_party/yasm/yasm_assemble.gni
index 5dc4c7c89dbb3e2f881032d366c877ed6cdc880c..78037b8e75327f22dee488215150ae46a139bd0e 100644
--- a/third_party/yasm/yasm_assemble.gni
+++ b/third_party/yasm/yasm_assemble.gni
@@ -110,7 +110,8 @@ template("yasm_assemble") {
source_set_name = target_name
action_foreach(action_name) {
- visibility = ":$source_set_name" # Only the source set can depend on this.
+ # Only the source set can depend on this.
+ visibility = [ ":$source_set_name" ]
script = "//third_party/yasm/run_yasm.py"
sources = invoker.sources
« no previous file with comments | « third_party/protobuf/proto_library.gni ('k') | tools/generate_library_loader/generate_library_loader.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698