third_party/yasm/yasm_assemble.gni - Issue 544423002: Convert GN visibility variables to lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/yasm/yasm_assemble.gni

Issue 544423002: Convert GN visibility variables to lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/yasm/yasm_assemble.gni

diff --git a/third_party/yasm/yasm_assemble.gni b/third_party/yasm/yasm_assemble.gni

index 5dc4c7c89dbb3e2f881032d366c877ed6cdc880c..78037b8e75327f22dee488215150ae46a139bd0e 100644

--- a/third_party/yasm/yasm_assemble.gni

+++ b/third_party/yasm/yasm_assemble.gni

@@ -110,7 +110,8 @@ template("yasm_assemble") {

source_set_name = target_name

action_foreach(action_name) {

- visibility = ":$source_set_name" # Only the source set can depend on this.

+ # Only the source set can depend on this.

+ visibility = [ ":$source_set_name" ]

script = "//third_party/yasm/run_yasm.py"

sources = invoker.sources