chrome/app/BUILD.gn - Issue 544423002: Convert GN visibility variables to lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/BUILD.gn

Issue 544423002: Convert GN visibility variables to lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/BUILD.gn

diff --git a/chrome/app/BUILD.gn b/chrome/app/BUILD.gn

index 3113d78bd02acb4451e10f9181b52c93ce3b575e..9a62322ba1279e9dfe489cd8633097cbc0fb58ee 100644

--- a/chrome/app/BUILD.gn

+++ b/chrome/app/BUILD.gn

@@ -72,7 +72,7 @@ grit("generated_resources") {

# GYP version: chrome/chrome_resources.gyp:chrome_strings_map

action("make_generated_resources_map") {

# Targets should depend on generated_resources_map instead.

- visibility = ":generated_resources_map"

+ visibility = [ ":generated_resources_map" ]

script = "//chrome/browser/metrics/variations/generate_resources_map.py"

« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/chrome_repack_locales.gni » ('j') | no next file with comments »