Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: build/secondary/third_party/nss/BUILD.gn

Issue 544423002: Convert GN visibility variables to lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/linux/pkg_config.gni") 5 import("//build/config/linux/pkg_config.gni")
6 6
7 if (is_linux) { 7 if (is_linux) {
8 # This is a dependency on NSS with no libssl. On Linux we use a built-in SSL 8 # This is a dependency on NSS with no libssl. On Linux we use a built-in SSL
9 # library but the system NSS libraries. Non-Linux platforms using NSS use the 9 # library but the system NSS libraries. Non-Linux platforms using NSS use the
10 # hermetic one in //third_party/nss. 10 # hermetic one in //third_party/nss.
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 # "exclude_nss_root_certs" is not specified, as "nss_static" depends on 378 # "exclude_nss_root_certs" is not specified, as "nss_static" depends on
379 # the "builtinsC_GetFunctionList" exported by this target. This is an 379 # the "builtinsC_GetFunctionList" exported by this target. This is an
380 # artifact of how NSS is being statically built, which is not an 380 # artifact of how NSS is being statically built, which is not an
381 # officially supported configuration - normally, "nssckbi.dll/so" would 381 # officially supported configuration - normally, "nssckbi.dll/so" would
382 # depend on libnss3.dll/so, and the higher layer caller would instruct 382 # depend on libnss3.dll/so, and the higher layer caller would instruct
383 # libnss3.dll to dynamically load nssckbi.dll, breaking the circle. 383 # libnss3.dll to dynamically load nssckbi.dll, breaking the circle.
384 # 384 #
385 # TODO(rsleevi): http://crbug.com/128134 - Break the circular dependency 385 # TODO(rsleevi): http://crbug.com/128134 - Break the circular dependency
386 # without requiring nssckbi to be built as a shared library. 386 # without requiring nssckbi to be built as a shared library.
387 source_set("nssckbi") { 387 source_set("nssckbi") {
388 visibility = ":nss" # This target is internal implementation detail. 388 visibility = [ ":nss" ] # This target is internal implementation detail.
389 389
390 sources = [ 390 sources = [
391 "nss/lib/ckfw/builtins/anchor.c", 391 "nss/lib/ckfw/builtins/anchor.c",
392 "nss/lib/ckfw/builtins/bfind.c", 392 "nss/lib/ckfw/builtins/bfind.c",
393 "nss/lib/ckfw/builtins/binst.c", 393 "nss/lib/ckfw/builtins/binst.c",
394 "nss/lib/ckfw/builtins/bobject.c", 394 "nss/lib/ckfw/builtins/bobject.c",
395 "nss/lib/ckfw/builtins/bsession.c", 395 "nss/lib/ckfw/builtins/bsession.c",
396 "nss/lib/ckfw/builtins/bslot.c", 396 "nss/lib/ckfw/builtins/bslot.c",
397 "nss/lib/ckfw/builtins/btoken.c", 397 "nss/lib/ckfw/builtins/btoken.c",
398 "nss/lib/ckfw/builtins/builtins.h", 398 "nss/lib/ckfw/builtins/builtins.h",
(...skipping 751 matching lines...) Expand 10 before | Expand all | Expand 10 after
1150 1150
1151 deps = [ 1151 deps = [
1152 ":nspr", 1152 ":nspr",
1153 "//third_party/sqlite", 1153 "//third_party/sqlite",
1154 ] 1154 ]
1155 1155
1156 forward_dependent_configs_from = [ ":nspr" ] 1156 forward_dependent_configs_from = [ ":nspr" ]
1157 } 1157 }
1158 } # Windows/Mac/iOS. 1158 } # Windows/Mac/iOS.
1159 1159
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698