Reorganize Layer Hoisting code

Reorganize Layer Hoisting code

With the new MultiPictureDraw API the GrContext will be performing the layer hoisting (instead of the SkGpuDevice). This CL being moving the layer hoisting functionality to GrLayerHoister rather then dumping it straight into GrContext.

Committed: https://skia.googlesource.com/skia/+/98d709bc8d0761df8e0ad35e92c06e500f0be50d

[robertphillips, 2014-09-02 15:17:25]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2014-09-02 15:26:20]

https://codereview.chromium.org/531733003/diff/1/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/531733003/diff/1/include/core/SkPicture.h#new...
include/core/SkPicture.h:297: friend class SkGpuDevice;                  // for
EXPERIMENTAL_getActiveOps/OperationList
still need this, right?

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.cpp
File src/gpu/GrLayerHoister.cpp (right):

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.cpp#n...
src/gpu/GrLayerHoister.cpp:40: if (pullForward[j]) {
Assuming caller init'ed to false?

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.h
File src/gpu/GrLayerHoister.h (right):

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.h#new...
src/gpu/GrLayerHoister.h:18: // This class collects the layer hoisting
functionality in one place.
namespace?

maybe a little bit more description here about how this is used?

I assume you call FindLayersToHoist() once for each picture, one call to
DrawLayers(), and then UnlockLayers() per-picture.

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.h#new...
src/gpu/GrLayerHoister.h:23: const SkRect& query,
pullForward[]?

comments on what the params mean?

[robertphillips, 2014-09-02 16:14:42]

https://codereview.chromium.org/531733003/diff/1/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/531733003/diff/1/include/core/SkPicture.h#new...
include/core/SkPicture.h:297: friend class SkGpuDevice;                  // for
EXPERIMENTAL_getActiveOps/OperationList
For right now. Once GrContext is doing everything it will go away.

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.cpp
File src/gpu/GrLayerHoister.cpp (right):

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.cpp#n...
src/gpu/GrLayerHoister.cpp:40: if (pullForward[j]) {
On 2014/09/02 15:26:20, bsalomon wrote:
> Assuming caller init'ed to false?

Done (moved init of 'pullForward' to the top of this method).

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.h
File src/gpu/GrLayerHoister.h (right):

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.h#new...
src/gpu/GrLayerHoister.h:18: // This class collects the layer hoisting
functionality in one place.
> namespace?

It's a class to provide a hook for friending.

> maybe a little bit more description here about how this is used?
> 
> I assume you call FindLayersToHoist() once for each picture, one call to
> DrawLayers(), and then UnlockLayers() per-picture.

Done.

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.h#new...
src/gpu/GrLayerHoister.h:23: const SkRect& query,
On 2014/09/02 15:26:20, bsalomon wrote:
> pullForward[]?
> 
> comments on what the params mean?

Done.

[bsalomon, 2014-09-02 16:58:14]

lgtm

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.h
File src/gpu/GrLayerHoister.h (right):

https://codereview.chromium.org/531733003/diff/1/src/gpu/GrLayerHoister.h#new...
src/gpu/GrLayerHoister.h:18: // This class collects the layer hoisting
functionality in one place.
On 2014/09/02 16:14:42, robertphillips wrote:
> > namespace?
> 
> It's a class to provide a hook for friending.
> 
> > maybe a little bit more description here about how this is used?
> > 
> > I assume you call FindLayersToHoist() once for each picture, one call to
> > DrawLayers(), and then UnlockLayers() per-picture.
> 
> Done.
oh, makes sense.

[robertphillips, 2014-09-02 17:11:51]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-09-02 17:12:58]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/531733003/2...

[commit-bot: I haz the power, 2014-09-02 17:20:55]

Committed patchset #2 (id:20001) as 98d709bc8d0761df8e0ad35e92c06e500f0be50d