Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 526223002: Use Chrome compatible naming for compiler specifics. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
Paweł Hajdan Jr., v8-dev
Project:
v8
Visibility:
Public.

Description

Use Chrome compatible naming for compiler specifics. Less useless creativity is best creativity! R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23579

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : clang-format #

Patch Set 4 : WARN_UNUSED_RESULT #

Patch Set 5 : mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3067 lines, -3050 lines) Patch
M include/v8config.h View 1 2 3 2 chunks +0 lines, -45 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.h View 148 chunks +204 lines, -204 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 15 chunks +39 lines, -39 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/lithium-arm64.h View 151 chunks +216 lines, -216 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ast.h View 91 chunks +207 lines, -207 lines 0 comments Download
M src/ast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast-value-factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ast-value-factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A src/base/compiler-specific.h View 1 2 3 1 chunk +58 lines, -0 lines 0 comments Download
M src/base/cpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/cpu.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/flags.h View 1 2 3 3 chunks +13 lines, -11 lines 0 comments Download
M src/base/macros.h View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M src/base/platform/condition-variable.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/base/platform/condition-variable-unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/base/platform/elapsed-timer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/mutex.h View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M src/base/platform/platform-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/base/platform/semaphore.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/platform/semaphore-unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/base/platform/time.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/base/platform/time.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/base/sys-info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/base/utils/random-number-generator.h View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M src/bootstrapper.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/code-stubs.h View 84 chunks +161 lines, -161 lines 0 comments Download
M src/compiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +9 lines, -9 lines 0 comments Download
M src/compiler/change-lowering.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/change-lowering-unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/code-generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/common-node-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/compiler-unittests.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/gap-resolver.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-reducer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/graph-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-unittest.cc View 34 chunks +38 lines, -38 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 8 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/instruction-selector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector-unittest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 4 chunks +20 lines, -20 lines 0 comments Download
M src/compiler/linkage.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/machine-operator-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/node-matchers.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/phi-reducer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/schedule.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/source-position.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/elements.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M src/execution.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/field-index.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 2 3 24 chunks +38 lines, -38 lines 0 comments Download
M src/hydrogen-gvn.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen-gvn.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 266 chunks +542 lines, -542 lines 0 comments Download
M src/hydrogen-types.h View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 15 chunks +39 lines, -39 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 143 chunks +201 lines, -201 lines 0 comments Download
M src/ic/ic.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/libplatform/task-queue-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/libplatform/worker-thread.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lithium.h View 7 chunks +7 lines, -7 lines 0 comments Download
M src/lookup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 15 chunks +39 lines, -39 lines 0 comments Download
M src/mips/lithium-gap-resolver-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 145 chunks +200 lines, -200 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 14 chunks +36 lines, -36 lines 0 comments Download
M src/mips64/lithium-gap-resolver-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-mips64.h View 144 chunks +199 lines, -199 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 14 chunks +28 lines, -28 lines 0 comments Download
M src/objects-inl.h View 8 chunks +14 lines, -14 lines 0 comments Download
M src/ostreams.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/parser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/preparser.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/property.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/serialize.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/snapshot-source-sink.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/string-stream.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/unique.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 15 chunks +39 lines, -39 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 144 chunks +203 lines, -203 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 16 chunks +39 lines, -39 lines 0 comments Download
M src/x87/lithium-gap-resolver-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-x87.h View 144 chunks +203 lines, -203 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-graph-reducer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-02 06:44:41 UTC) #1
Sven Panne
LGTM. Less useless creativity is best creativity! :-D
6 years, 3 months ago (2014-09-02 06:47:47 UTC) #2
Benedikt Meurer
6 years, 3 months ago (2014-09-02 07:09:16 UTC) #3
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 23579 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698