Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: src/base/flags.h

Issue 526223002: Use Chrome compatible naming for compiler specifics. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: mips Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/base/cpu.cc ('k') | src/base/macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/flags.h
diff --git a/src/base/flags.h b/src/base/flags.h
index bf5edbf3f31a17ca7d7faad665972a6d76e5eb88..eb7358755f46bcde203cff195364aa6e1f00df4e 100644
--- a/src/base/flags.h
+++ b/src/base/flags.h
@@ -5,7 +5,7 @@
#ifndef V8_BASE_FLAGS_H_
#define V8_BASE_FLAGS_H_
-#include "include/v8config.h"
+#include "src/base/compiler-specific.h"
namespace v8 {
namespace base {
@@ -20,7 +20,7 @@ namespace base {
// other enum value and passed on to a function that takes an int or unsigned
// int.
template <typename T, typename S = int>
-class Flags V8_FINAL {
+class Flags FINAL {
public:
typedef T flag_type;
typedef S mask_type;
@@ -67,50 +67,52 @@ class Flags V8_FINAL {
#define DEFINE_OPERATORS_FOR_FLAGS(Type) \
inline ::v8::base::Flags<Type::flag_type> operator&( \
Type::flag_type lhs, \
- Type::flag_type rhs)V8_UNUSED V8_WARN_UNUSED_RESULT; \
+ Type::flag_type rhs)ALLOW_UNUSED WARN_UNUSED_RESULT; \
inline ::v8::base::Flags<Type::flag_type> operator&(Type::flag_type lhs, \
Type::flag_type rhs) { \
return ::v8::base::Flags<Type::flag_type>(lhs) & rhs; \
} \
inline ::v8::base::Flags<Type::flag_type> operator&( \
Type::flag_type lhs, const ::v8::base::Flags<Type::flag_type>& rhs) \
- V8_UNUSED V8_WARN_UNUSED_RESULT; \
+ ALLOW_UNUSED WARN_UNUSED_RESULT; \
inline ::v8::base::Flags<Type::flag_type> operator&( \
Type::flag_type lhs, const ::v8::base::Flags<Type::flag_type>& rhs) { \
return rhs & lhs; \
} \
- inline void operator&(Type::flag_type lhs, Type::mask_type rhs)V8_UNUSED; \
+ inline void operator&(Type::flag_type lhs, Type::mask_type rhs)ALLOW_UNUSED; \
inline void operator&(Type::flag_type lhs, Type::mask_type rhs) {} \
inline ::v8::base::Flags<Type::flag_type> operator|(Type::flag_type lhs, \
Type::flag_type rhs) \
- V8_UNUSED V8_WARN_UNUSED_RESULT; \
+ ALLOW_UNUSED WARN_UNUSED_RESULT; \
inline ::v8::base::Flags<Type::flag_type> operator|(Type::flag_type lhs, \
Type::flag_type rhs) { \
return ::v8::base::Flags<Type::flag_type>(lhs) | rhs; \
} \
inline ::v8::base::Flags<Type::flag_type> operator|( \
Type::flag_type lhs, const ::v8::base::Flags<Type::flag_type>& rhs) \
- V8_UNUSED V8_WARN_UNUSED_RESULT; \
+ ALLOW_UNUSED WARN_UNUSED_RESULT; \
inline ::v8::base::Flags<Type::flag_type> operator|( \
Type::flag_type lhs, const ::v8::base::Flags<Type::flag_type>& rhs) { \
return rhs | lhs; \
} \
- inline void operator|(Type::flag_type lhs, Type::mask_type rhs) V8_UNUSED; \
+ inline void operator|(Type::flag_type lhs, Type::mask_type rhs) \
+ ALLOW_UNUSED; \
inline void operator|(Type::flag_type lhs, Type::mask_type rhs) {} \
inline ::v8::base::Flags<Type::flag_type> operator^(Type::flag_type lhs, \
Type::flag_type rhs) \
- V8_UNUSED V8_WARN_UNUSED_RESULT; \
+ ALLOW_UNUSED WARN_UNUSED_RESULT; \
inline ::v8::base::Flags<Type::flag_type> operator^(Type::flag_type lhs, \
Type::flag_type rhs) { \
return ::v8::base::Flags<Type::flag_type>(lhs) ^ rhs; \
} inline ::v8::base::Flags<Type::flag_type> \
operator^(Type::flag_type lhs, \
const ::v8::base::Flags<Type::flag_type>& rhs) \
- V8_UNUSED V8_WARN_UNUSED_RESULT; \
+ ALLOW_UNUSED WARN_UNUSED_RESULT; \
inline ::v8::base::Flags<Type::flag_type> operator^( \
Type::flag_type lhs, const ::v8::base::Flags<Type::flag_type>& rhs) { \
return rhs ^ lhs; \
- } inline void operator^(Type::flag_type lhs, Type::mask_type rhs) V8_UNUSED; \
+ } inline void operator^(Type::flag_type lhs, Type::mask_type rhs) \
+ ALLOW_UNUSED; \
inline void operator^(Type::flag_type lhs, Type::mask_type rhs) {}
} // namespace base
« no previous file with comments | « src/base/cpu.cc ('k') | src/base/macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698