Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: src/base/platform/semaphore-unittest.cc

Issue 526223002: Use Chrome compatible naming for compiler specifics. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: mips Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/base/platform/semaphore.h ('k') | src/base/platform/time.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/platform/semaphore-unittest.cc
diff --git a/src/base/platform/semaphore-unittest.cc b/src/base/platform/semaphore-unittest.cc
index 836e7192603367409604f37a401c11c6b8a7cc5a..c68435f87524f36d7490b8b6d8ffef6da5a228c7 100644
--- a/src/base/platform/semaphore-unittest.cc
+++ b/src/base/platform/semaphore-unittest.cc
@@ -20,7 +20,7 @@ static const size_t kBufferSize = 987; // GCD(buffer size, alphabet size) = 1
static const size_t kDataSize = kBufferSize * kAlphabetSize * 10;
-class ProducerThread V8_FINAL : public Thread {
+class ProducerThread FINAL : public Thread {
public:
ProducerThread(char* buffer, Semaphore* free_space, Semaphore* used_space)
: Thread(Options("ProducerThread")),
@@ -29,7 +29,7 @@ class ProducerThread V8_FINAL : public Thread {
used_space_(used_space) {}
virtual ~ProducerThread() {}
- virtual void Run() V8_OVERRIDE {
+ virtual void Run() OVERRIDE {
for (size_t n = 0; n < kDataSize; ++n) {
free_space_->Wait();
buffer_[n % kBufferSize] = kAlphabet[n % kAlphabetSize];
@@ -44,7 +44,7 @@ class ProducerThread V8_FINAL : public Thread {
};
-class ConsumerThread V8_FINAL : public Thread {
+class ConsumerThread FINAL : public Thread {
public:
ConsumerThread(const char* buffer, Semaphore* free_space,
Semaphore* used_space)
@@ -54,7 +54,7 @@ class ConsumerThread V8_FINAL : public Thread {
used_space_(used_space) {}
virtual ~ConsumerThread() {}
- virtual void Run() V8_OVERRIDE {
+ virtual void Run() OVERRIDE {
for (size_t n = 0; n < kDataSize; ++n) {
used_space_->Wait();
EXPECT_EQ(kAlphabet[n % kAlphabetSize], buffer_[n % kBufferSize]);
@@ -69,13 +69,13 @@ class ConsumerThread V8_FINAL : public Thread {
};
-class WaitAndSignalThread V8_FINAL : public Thread {
+class WaitAndSignalThread FINAL : public Thread {
public:
explicit WaitAndSignalThread(Semaphore* semaphore)
: Thread(Options("WaitAndSignalThread")), semaphore_(semaphore) {}
virtual ~WaitAndSignalThread() {}
- virtual void Run() V8_OVERRIDE {
+ virtual void Run() OVERRIDE {
for (int n = 0; n < 100; ++n) {
semaphore_->Wait();
ASSERT_FALSE(semaphore_->WaitFor(TimeDelta::FromMicroseconds(1)));
« no previous file with comments | « src/base/platform/semaphore.h ('k') | src/base/platform/time.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698