Source/web/ChromeClientImpl.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index 3a2b428185978edf3a9687f8a4cd37d81e6c403b..87b30bb15e09b6cd22bb897ac5202474390aeaf6 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -707,12 +707,12 @@ bool ChromeClientImpl::hasOpenedPopup() const

return m_webView->hasOpenedPopup();

}

-PassRefPtr<PopupMenu> ChromeClientImpl::createPopupMenu(LocalFrame& frame, PopupMenuClient* client) const

+PassRefPtrWillBeRawPtr<PopupMenu> ChromeClientImpl::createPopupMenu(LocalFrame& frame, PopupMenuClient* client) const

{

if (WebViewImpl::useExternalPopupMenus())

- return adoptRef(new ExternalPopupMenu(frame, client, *m_webView));

+ return adoptRefWillBeNoop(new ExternalPopupMenu(frame, client, *m_webView));

- return adoptRef(new PopupMenuChromium(frame, client));

+ return adoptRefWillBeNoop(new PopupMenuChromium(frame, client));

}

PagePopup* ChromeClientImpl::openPagePopup(PagePopupClient* client, const IntRect& originBoundsInRootView)