Source/web/ChromeClientImpl.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ChromeClientImpl.h

diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h

index 61f1ebcabf7885717f2a42e9a43551919ef616d0..89ffadcfd94d10e041da8e4f1353d796d771c238 100644

--- a/Source/web/ChromeClientImpl.h

+++ b/Source/web/ChromeClientImpl.h

@@ -155,7 +155,7 @@ public:

void setNewWindowNavigationPolicy(WebNavigationPolicy);

virtual bool hasOpenedPopup() const OVERRIDE;

- virtual PassRefPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) const OVERRIDE;

+ virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) const OVERRIDE;

PagePopup* openPagePopup(PagePopupClient*, const IntRect&);

void closePagePopup(PagePopup*);

virtual void setPagePopupDriver(PagePopupDriver*) OVERRIDE;