Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2039)

Unified Diff: Source/core/xml/parser/XMLDocumentParser.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/xml/parser/XMLDocumentParser.cpp
diff --git a/Source/core/xml/parser/XMLDocumentParser.cpp b/Source/core/xml/parser/XMLDocumentParser.cpp
index c53a660612afb98fc957edb2eed1676e70a74a1c..21545a81d4800a3b9498283d90811220890c1c3c 100644
--- a/Source/core/xml/parser/XMLDocumentParser.cpp
+++ b/Source/core/xml/parser/XMLDocumentParser.cpp
@@ -1007,6 +1007,13 @@ void XMLDocumentParser::startElementNs(const AtomicString& localName, const Atom
m_currentNode->parserAppendChild(newElement.get());
+ // Event handlers may synchronously trigger removal of the
+ // document and cancellation of this parser.
haraken 2014/09/22 05:35:23 Just help me understand: What's the relationship b
sof 2014/09/22 07:47:43 The frame might now be detached as a result of syn
+ if (isStopped()) {
+ stopParsing();
+ return;
+ }
+
if (isHTMLTemplateElement(*newElement))
pushCurrentNode(toHTMLTemplateElement(*newElement).content());
else

Powered by Google App Engine
This is Rietveld 408576698