Source/web/DragClientImpl.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/DragClientImpl.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/DragClientImpl.cpp

diff --git a/Source/web/DragClientImpl.cpp b/Source/web/DragClientImpl.cpp

index 23876d1858083225d81161cfe7be0ca93542a357..9b75f1223215a8a08b50709c8356886798b5b8e6 100644

--- a/Source/web/DragClientImpl.cpp

+++ b/Source/web/DragClientImpl.cpp

@@ -61,7 +61,7 @@ DragDestinationAction DragClientImpl::actionMaskForDrag(DragData*)

void DragClientImpl::startDrag(DragImage* dragImage, const IntPoint& dragImageOrigin, const IntPoint& eventPos, DataTransfer* dataTransfer, LocalFrame* frame, bool isLinkDrag)

{

// Add a ref to the frame just in case a load occurs mid-drag.

- RefPtr<LocalFrame> frameProtector = frame;

+ RefPtrWillBeRawPtr<LocalFrame> frameProtector(frame);

WebDragData dragData(dataTransfer->dataObject());

WebDragOperationsMask dragOperationMask = static_cast<WebDragOperationsMask>(dataTransfer->sourceOperation());

« Source/core/xml/parser/XMLDocumentParser.cpp ('K') | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/ExternalPopupMenu.h » ('j') | Source/web/WebFrame.cpp » ('J')