Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Side by Side Diff: Source/web/ChromeClientImpl.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 void ChromeClientImpl::clearCompositedSelectionBounds() 700 void ChromeClientImpl::clearCompositedSelectionBounds()
701 { 701 {
702 m_webView->clearCompositedSelectionBounds(); 702 m_webView->clearCompositedSelectionBounds();
703 } 703 }
704 704
705 bool ChromeClientImpl::hasOpenedPopup() const 705 bool ChromeClientImpl::hasOpenedPopup() const
706 { 706 {
707 return m_webView->hasOpenedPopup(); 707 return m_webView->hasOpenedPopup();
708 } 708 }
709 709
710 PassRefPtr<PopupMenu> ChromeClientImpl::createPopupMenu(LocalFrame& frame, Popup MenuClient* client) const 710 PassRefPtrWillBeRawPtr<PopupMenu> ChromeClientImpl::createPopupMenu(LocalFrame& frame, PopupMenuClient* client) const
711 { 711 {
712 if (WebViewImpl::useExternalPopupMenus()) 712 if (WebViewImpl::useExternalPopupMenus())
713 return adoptRef(new ExternalPopupMenu(frame, client, *m_webView)); 713 return adoptRefWillBeNoop(new ExternalPopupMenu(frame, client, *m_webVie w));
714 714
715 return adoptRef(new PopupMenuChromium(frame, client)); 715 return adoptRefWillBeNoop(new PopupMenuChromium(frame, client));
716 } 716 }
717 717
718 PagePopup* ChromeClientImpl::openPagePopup(PagePopupClient* client, const IntRec t& originBoundsInRootView) 718 PagePopup* ChromeClientImpl::openPagePopup(PagePopupClient* client, const IntRec t& originBoundsInRootView)
719 { 719 {
720 ASSERT(m_pagePopupDriver); 720 ASSERT(m_pagePopupDriver);
721 return m_pagePopupDriver->openPagePopup(client, originBoundsInRootView); 721 return m_pagePopupDriver->openPagePopup(client, originBoundsInRootView);
722 } 722 }
723 723
724 void ChromeClientImpl::closePagePopup(PagePopup* popup) 724 void ChromeClientImpl::closePagePopup(PagePopup* popup)
725 { 725 {
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
869 m_webView->autofillClient()->textFieldDidEndEditing(WebInputElement(&inp utElement)); 869 m_webView->autofillClient()->textFieldDidEndEditing(WebInputElement(&inp utElement));
870 } 870 }
871 871
872 void ChromeClientImpl::openTextDataListChooser(HTMLInputElement& input) 872 void ChromeClientImpl::openTextDataListChooser(HTMLInputElement& input)
873 { 873 {
874 if (m_webView->autofillClient()) 874 if (m_webView->autofillClient())
875 m_webView->autofillClient()->openTextDataListChooser(WebInputElement(&in put)); 875 m_webView->autofillClient()->openTextDataListChooser(WebInputElement(&in put));
876 } 876 }
877 877
878 } // namespace blink 878 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698