Source/core/page/Chrome.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Chrome.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/Chrome.cpp

diff --git a/Source/core/page/Chrome.cpp b/Source/core/page/Chrome.cpp

index 3115ffe7b49d35df18c28d29c88b02725154aabb..3fdd3aee51d098cd8e36138f8cc78fa8406f7e86 100644

--- a/Source/core/page/Chrome.cpp

+++ b/Source/core/page/Chrome.cpp

@@ -377,7 +377,7 @@ bool Chrome::hasOpenedPopup() const

return m_client->hasOpenedPopup();

}

-PassRefPtr<PopupMenu> Chrome::createPopupMenu(LocalFrame& frame, PopupMenuClient* client) const

+PassRefPtrWillBeRawPtr<PopupMenu> Chrome::createPopupMenu(LocalFrame& frame, PopupMenuClient* client) const

{

notifyPopupOpeningObservers();

return m_client->createPopupMenu(frame, client);