Source/core/page/Chrome.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Chrome.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/Chrome.h

diff --git a/Source/core/page/Chrome.h b/Source/core/page/Chrome.h

index f3bd097674a1c1dc6d08f18122705c9a785e4987..e862492fb4f2f6dbc873f9c37567b8315884da09 100644

--- a/Source/core/page/Chrome.h

+++ b/Source/core/page/Chrome.h

@@ -26,6 +26,7 @@

#include "core/page/FocusType.h"

#include "platform/Cursor.h"

#include "platform/HostWindow.h"

+#include "platform/heap/Handle.h"

#include "wtf/Forward.h"

namespace blink {

@@ -125,7 +126,7 @@ public:

void dispatchViewportPropertiesDidChange(const ViewportDescription&) const;

bool hasOpenedPopup() const;

- PassRefPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) const;

+ PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) const;

void registerPopupOpeningObserver(PopupOpeningObserver*);

void unregisterPopupOpeningObserver(PopupOpeningObserver*);