Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: Source/core/page/Chrome.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2012, Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012, Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 m_client->scheduleAnimation(); 370 m_client->scheduleAnimation();
371 } 371 }
372 372
373 // -------- 373 // --------
374 374
375 bool Chrome::hasOpenedPopup() const 375 bool Chrome::hasOpenedPopup() const
376 { 376 {
377 return m_client->hasOpenedPopup(); 377 return m_client->hasOpenedPopup();
378 } 378 }
379 379
380 PassRefPtr<PopupMenu> Chrome::createPopupMenu(LocalFrame& frame, PopupMenuClient * client) const 380 PassRefPtrWillBeRawPtr<PopupMenu> Chrome::createPopupMenu(LocalFrame& frame, Pop upMenuClient* client) const
381 { 381 {
382 notifyPopupOpeningObservers(); 382 notifyPopupOpeningObservers();
383 return m_client->createPopupMenu(frame, client); 383 return m_client->createPopupMenu(frame, client);
384 } 384 }
385 385
386 void Chrome::registerPopupOpeningObserver(PopupOpeningObserver* observer) 386 void Chrome::registerPopupOpeningObserver(PopupOpeningObserver* observer)
387 { 387 {
388 ASSERT(observer); 388 ASSERT(observer);
389 m_popupOpeningObservers.append(observer); 389 m_popupOpeningObservers.append(observer);
390 } 390 }
(...skipping 11 matching lines...) Expand all
402 for (size_t i = 0; i < observers.size(); ++i) 402 for (size_t i = 0; i < observers.size(); ++i)
403 observers[i]->willOpenPopup(); 403 observers[i]->willOpenPopup();
404 } 404 }
405 405
406 void Chrome::willBeDestroyed() 406 void Chrome::willBeDestroyed()
407 { 407 {
408 m_client->chromeDestroyed(); 408 m_client->chromeDestroyed();
409 } 409 }
410 410
411 } // namespace blink 411 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698