Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: Source/core/page/FrameTree.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/FrameTree.h
diff --git a/Source/core/page/FrameTree.h b/Source/core/page/FrameTree.h
index e2f8fcdf392e34bd3da6ca845f3e33e246ad323f..4213ea9679f17a8ab4bfad50ea31e7dd9094744b 100644
--- a/Source/core/page/FrameTree.h
+++ b/Source/core/page/FrameTree.h
@@ -20,6 +20,7 @@
#ifndef FrameTree_h
#define FrameTree_h
+#include "platform/heap/Handle.h"
#include "wtf/text/AtomicString.h"
namespace blink {
@@ -27,8 +28,9 @@ namespace blink {
class Frame;
class TreeScope;
-class FrameTree {
+class FrameTree FINAL {
WTF_MAKE_NONCOPYABLE(FrameTree);
+ ALLOW_ONLY_INLINE_ALLOCATION();
haraken 2014/09/22 05:35:23 DISALLOW_ALLOCATION() ?
public:
explicit FrameTree(Frame* thisFrame);
~FrameTree();
@@ -60,13 +62,15 @@ public:
unsigned scopedChildCount() const;
void invalidateScopedChildCount();
+ void trace(Visitor*);
+
private:
Frame* deepLastChild() const;
AtomicString uniqueChildName(const AtomicString& requestedName) const;
bool uniqueNameExists(const AtomicString& name) const;
unsigned scopedChildCount(TreeScope*) const;
- Frame* m_thisFrame;
+ RawPtrWillBeMember<Frame> m_thisFrame;
AtomicString m_name; // The actual frame name (may be empty).
AtomicString m_uniqueName;

Powered by Google App Engine
This is Rietveld 408576698