Source/core/page/ChromeClient.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/ChromeClient.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/ChromeClient.h

diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h

index eaf97c8f3bb771bd38bd9e3fda056f0b28e9ff3c..72a777ecec1f05be7154ea80c912734059facee8 100644

--- a/Source/core/page/ChromeClient.h

+++ b/Source/core/page/ChromeClient.h

@@ -33,6 +33,7 @@

#include "platform/HostWindow.h"

#include "platform/PopupMenu.h"

#include "platform/PopupMenuClient.h"

+#include "platform/heap/Handle.h"

#include "platform/scroll/ScrollTypes.h"

#include "wtf/Forward.h"

#include "wtf/PassOwnPtr.h"

@@ -193,7 +194,7 @@ public:

// Checks if there is an opened popup, called by RenderMenuList::showPopup().

virtual bool hasOpenedPopup() const = 0;

- virtual PassRefPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) const = 0;

+ virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) const = 0;

// For testing.

virtual void setPagePopupDriver(PagePopupDriver*) = 0;

virtual void resetPagePopupDriver() = 0;