Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 512003002: Revert of Revert "Typecheck JS files for chrome://extensions" (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
Vitaly Pavlenko, eroman
CC:
chromium-reviews, extensions-reviews_chromium.org, dcheng, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Typecheck JS files for chrome://extensions" (patchset #1 of https://codereview.chromium.org/508283002/) Reason for revert: fixed check_licenses issues Original issue's description: > Revert "Typecheck JS files for chrome://extensions" > > This reverts commit 405253b7ee22ecb318d3c1ca9187e1e7259e704f. > > Caused a liscene failure on android bot: > http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64664/steps/check_licenses/logs/stdio > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/87b3206 TBR=vitalyp@chromium.org,eroman@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9a5ab1949738fac262adbcf125004f7b1f62e7e9 Cr-Commit-Position: refs/heads/master@{#292229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -187 lines) Patch
M chrome/browser/resources/extensions/chromeos/kiosk_app_list.js View 3 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/resources/extensions/chromeos/kiosk_apps.js View 2 chunks +4 lines, -4 lines 0 comments Download
A chrome/browser/resources/extensions/compiled_resources.gyp View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/resources/extensions/extension_code.js View 3 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/resources/extensions/extension_command_list.js View 14 chunks +24 lines, -13 lines 0 comments Download
M chrome/browser/resources/extensions/extension_commands_overlay.js View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/extensions/extension_error.js View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/extensions/extension_error_overlay.js View 17 chunks +73 lines, -43 lines 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 5 chunks +58 lines, -4 lines 0 comments Download
M chrome/browser/resources/extensions/extension_loader.js View 7 chunks +28 lines, -21 lines 0 comments Download
M chrome/browser/resources/extensions/extension_options_overlay.js View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 4 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/resources/extensions/pack_extension_overlay.js View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/browser/extension_error.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr/event_target.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/alert_overlay.js View 2 chunks +15 lines, -15 lines 0 comments Download
M ui/webui/resources/js/cr/ui/array_data_model.js View 9 chunks +18 lines, -13 lines 0 comments Download
M ui/webui/resources/js/cr/ui/drag_wrapper.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/grid.js View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/list.js View 14 chunks +35 lines, -34 lines 0 comments Download
M ui/webui/resources/js/cr/ui/list_item.js View 3 chunks +1 line, -4 lines 0 comments Download
M ui/webui/resources/js/cr/ui/list_selection_controller.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/list_selection_model.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Revert "Typecheck JS files for chrome://extensions"
6 years, 3 months ago (2014-08-27 21:25:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/512003002/1
6 years, 3 months ago (2014-08-27 21:27:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9322608cce3fd8f52af39613bdaf52fac4ea3398
6 years, 3 months ago (2014-08-27 21:30:39 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a5ab1949738fac262adbcf125004f7b1f62e7e9
Cr-Commit-Position: refs/heads/master@{#292229}

Powered by Google App Engine
This is Rietveld 408576698