ui/webui/resources/js/cr/ui/grid.js - Issue 512003002: Revert of Revert "Typecheck JS files for chrome://extensions"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/grid.js

Issue 512003002: Revert of Revert "Typecheck JS files for chrome://extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/grid.js

diff --git a/ui/webui/resources/js/cr/ui/grid.js b/ui/webui/resources/js/cr/ui/grid.js

index 1203cf4f2f7fa078befc3ccdc8755bb7e2ea29dd..ecfc56eb580220be567b0cfef1573cedadc1e911 100644

--- a/ui/webui/resources/js/cr/ui/grid.js

+++ b/ui/webui/resources/js/cr/ui/grid.js

@@ -89,6 +89,9 @@

getColumnCount_: function() {

// Size comes here with margin already collapsed.

var size = this.getDefaultItemSize_();

+ if (!size)

+ return 0;

// We should uncollapse margin, since margin isn't collapsed for

// inline-block elements according to css spec which are thumbnail items.

« no previous file with comments | « ui/webui/resources/js/cr/ui/drag_wrapper.js ('k') | ui/webui/resources/js/cr/ui/list.js » ('j') | no next file with comments »