Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4327)

Unified Diff: chrome/browser/resources/extensions/chromeos/kiosk_app_list.js

Issue 512003002: Revert of Revert "Typecheck JS files for chrome://extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/chromeos/kiosk_apps.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/chromeos/kiosk_app_list.js
diff --git a/chrome/browser/resources/extensions/chromeos/kiosk_app_list.js b/chrome/browser/resources/extensions/chromeos/kiosk_app_list.js
index 3652f95bd6d7c2f17ba915270112e04d73ba7abc..28b0b3a921f1de45389a832841a070d295d88ae1 100644
--- a/chrome/browser/resources/extensions/chromeos/kiosk_app_list.js
+++ b/chrome/browser/resources/extensions/chromeos/kiosk_app_list.js
@@ -1,6 +1,18 @@
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+
+/**
+ * The type of the app data object. The definition is based on
+ * chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc:
+ * PopulateAppDict()
+ * @typedef {{id: string,
+ * name: string,
+ * iconURL: string,
+ * autoLaunch: boolean,
+ * isLoading: boolean}}
+ */
+var AppDict;
cr.define('extensions', function() {
/** @const */ var List = cr.ui.List;
@@ -49,7 +61,7 @@
/**
* Updates the given app.
- * @param {!Object} app An app info object.
+ * @param {!AppDict} app An app info object.
*/
updateApp: function(app) {
for (var i = 0; i < this.items.length; ++i) {
@@ -155,9 +167,8 @@
}
};
- /*
+ /**
* True if the app represented by this item will auto launch.
- * @type {boolean}
*/
cr.defineProperty(KioskAppListItem, 'autoLaunch', cr.PropertyKind.BOOL_ATTR);
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/chromeos/kiosk_apps.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698