Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: extensions/browser/extension_error.cc

Issue 512003002: Revert of Revert "Typecheck JS files for chrome://extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_error.cc
diff --git a/extensions/browser/extension_error.cc b/extensions/browser/extension_error.cc
index d8733fe51dc0234222f57984b487615512137855..19a31ea9ed529a6fdce9da60559bd23a6a09f17e 100644
--- a/extensions/browser/extension_error.cc
+++ b/extensions/browser/extension_error.cc
@@ -158,6 +158,10 @@
}
scoped_ptr<DictionaryValue> RuntimeError::ToValue() const {
+ // The items which are to be written into value are also described in
+ // chrome/browser/resources/extensions/extension_error_overlay.js in @typedef
+ // for RuntimeError and StackTrace. Please update them whenever you add or
+ // remove any keys here.
scoped_ptr<DictionaryValue> value = ExtensionError::ToValue();
value->SetString(kContextUrlKey, context_url_.spec());
value->SetInteger(kRenderViewIdKey, render_view_id_);
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | ui/webui/resources/js/cr/event_target.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698