chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc - Issue 512003002: Revert of Revert "Typecheck JS files for chrome://extensions"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

Issue 512003002: Revert of Revert "Typecheck JS files for chrome://extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/extensions/pack_extension_overlay.js ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc b/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

index d5d5660b50d93e75826e9be458a07768c0cfe104..93b889d9d51f71215efcc2010af54f1c4db367af 100644

--- a/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

+++ b/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

@@ -42,6 +42,9 @@

if (!app_data.icon.isNull())

icon_url = webui::GetBitmapDataUrl(*app_data.icon.bitmap());

+ // The items which are to be written into app_dict are also described in

+ // chrome/browser/resources/extensions/chromeos/kiosk_app_list.js in @typedef

+ // for AppDict. Please update it whenever you add or remove any keys here.

app_dict->SetString("id", app_data.app_id);

app_dict->SetString("name", app_data.name);

app_dict->SetString("iconURL", icon_url);