Remove virtual where not needed in TextTrackCue

Remove virtual where not needed in TextTrackCue

Remove TextTrackCue::cueType() since it always returned CueType::WebVTT
and was never overriden. CueType::Generic was for TextTrackCueGeneric
which was removed in r158977.

Remove TextTrackCue::videoSizeDidChange(...) since it did nothing and
was never overridden. This looks like unfinished logic for moving cues
when the controls are shown and hidden, and could be revived in
<http://crbug.com/314066>;.

BUG=313287
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161172

[philipj_slow, 2013-11-01 08:32:12]

I was wrong about applyCSSProperties, fixed that now...

[vcarbune.chromium, 2013-11-01 08:44:00]

On 2013/11/01 08:32:12, philipj wrote:
> I was wrong about applyCSSProperties, fixed that now...

LGTM, thanks for all these cleanups!

[vcarbune.chromium, 2013-11-01 09:55:37]

https://codereview.chromium.org/50903009/diff/70001/Source/core/html/track/Te...
File Source/core/html/track/TextTrackCue.h (left):

https://codereview.chromium.org/50903009/diff/70001/Source/core/html/track/Te...
Source/core/html/track/TextTrackCue.h:52: class TextTrackCueBox : public
HTMLDivElement {
Add FINAL to TextTrackCueBox ?

[philipj_slow, 2013-11-01 11:39:25]

https://codereview.chromium.org/50903009/diff/70001/Source/core/html/track/Te...
File Source/core/html/track/TextTrackCue.h (left):

https://codereview.chromium.org/50903009/diff/70001/Source/core/html/track/Te...
Source/core/html/track/TextTrackCue.h:52: class TextTrackCueBox : public
HTMLDivElement {
On 2013/11/01 09:55:37, vcarbune.chromium wrote:
> Add FINAL to TextTrackCueBox ?

Done.

[Mike West, 2013-11-01 14:15:20]

LGTM, but please add some detail to the CL description about what code you're
removing and why it's safe to remove. "some code that doesn't do anything" isn't
particularly helpful when someone comes back to this CL in `git blame` next
year.

[commit-bot: I haz the power, 2013-11-01 14:34:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/50903009/190001

[commit-bot: I haz the power, 2013-11-01 16:02:48]

Change committed as 161172