Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: Source/core/html/track/TextTrackCue.cpp

Issue 50903009: Remove virtual where not needed in TextTrackCue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add FINAL to TextTrackCueBox Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/track/TextTrackCue.h ('k') | Source/core/rendering/RenderTextTrackCue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1190 matching lines...) Expand 10 before | Expand all | Expand 10 after
1201 } 1201 }
1202 1202
1203 Document& TextTrackCue::document() const 1203 Document& TextTrackCue::document() const
1204 { 1204 {
1205 ASSERT(m_cueBackgroundBox); 1205 ASSERT(m_cueBackgroundBox);
1206 return m_cueBackgroundBox->document(); 1206 return m_cueBackgroundBox->document();
1207 } 1207 }
1208 1208
1209 bool TextTrackCue::operator==(const TextTrackCue& cue) const 1209 bool TextTrackCue::operator==(const TextTrackCue& cue) const
1210 { 1210 {
1211 if (cueType() != cue.cueType())
1212 return false;
1213
1214 if (m_endTime != cue.endTime()) 1211 if (m_endTime != cue.endTime())
1215 return false; 1212 return false;
1216 if (m_startTime != cue.startTime()) 1213 if (m_startTime != cue.startTime())
1217 return false; 1214 return false;
1218 if (m_content != cue.text()) 1215 if (m_content != cue.text())
1219 return false; 1216 return false;
1220 if (m_settings != cue.cueSettings()) 1217 if (m_settings != cue.cueSettings())
1221 return false; 1218 return false;
1222 if (m_id != cue.id()) 1219 if (m_id != cue.id())
1223 return false; 1220 return false;
1224 if (m_textPosition != cue.position()) 1221 if (m_textPosition != cue.position())
1225 return false; 1222 return false;
1226 if (m_linePosition != cue.line()) 1223 if (m_linePosition != cue.line())
1227 return false; 1224 return false;
1228 if (m_cueSize != cue.size()) 1225 if (m_cueSize != cue.size())
1229 return false; 1226 return false;
1230 if (align() != cue.align()) 1227 if (align() != cue.align())
1231 return false; 1228 return false;
1232 1229
1233 return true; 1230 return true;
1234 } 1231 }
1235 1232
1236 } // namespace WebCore 1233 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/track/TextTrackCue.h ('k') | Source/core/rendering/RenderTextTrackCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698